shengxinhu opened a new pull request #9767:
URL: https://github.com/apache/tvm/pull/9767


   I think current check_ function in PatternPartitioner should only check 
exprs in current matched group, exclude of exprs outside of the matched 
group(these exprs are  deemed as args of current group). For example, if a 
target has a very special requirement for nn.pad, such as requires pad_value 
equal to 0. we has defined thousands of patterns for the target and nn.pad 
exists in many of them. Current check_ function is impossible to distinguish 
nn.pad in current group from nn.pad in args of current group, but I only care 
about whether nn.pad in current group  is valid for the target.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to