kparzysz-quic commented on pull request #9904: URL: https://github.com/apache/tvm/pull/9904#issuecomment-1011654118
As it is now, it breaks TVM builds that do not set that variable, because the guarded parts want to use functions that were not compiled. I don't think it's a good idea to have the TVM build automatically build any apps. It happens to work with the launcher, but it's probably a bad precedent. If anything, the reverse should be the primary scenario---apps should build TVM runtimes configured to the apps' needs. I'm going to remove the external projects from Hexagon.cmake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
