kparzysz-quic edited a comment on pull request #9904: URL: https://github.com/apache/tvm/pull/9904#issuecomment-1011654118
As it is now, it breaks TVM builds that do not set that variable, because the guarded parts want to use functions that were not compiled. I don't think it's a good idea to have the TVM build automatically build any apps. It happens to work with the launcher, but it's probably a bad precedent. If anything, the reverse should be the primary scenario---apps should build TVM runtimes configured to the apps' needs. I'm going to remove the external projects from Hexagon.cmake. That should simplify the .cmake file at the expense of a bit of inconvenience. When we auto build an app, the crux of the issue is whether we want to use the currently built TVM runtime with that app. If so, then we need to make sure that the specified TVM build configuration meets the app's expectations, which is something that TVM's cmake files should not be bothered doing. Edit: added more rationale for not auto-building apps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
