jwfromm commented on a change in pull request #9811:
URL: https://github.com/apache/tvm/pull/9811#discussion_r787090528
##########
File path: src/runtime/graph_executor/graph_executor_factory.cc
##########
@@ -57,6 +58,14 @@ PackedFunc GraphExecutorFactory::GetFunction(
return PackedFunc(
[sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { *rv =
this->graph_json_; });
+ } else if (name == "get_graph_params") {
Review comment:
I think it'd be worth adding a test that you can take a compiled module,
call `set_params` then `get_graph_params` (which we might want to rename to
`get_params` for parity) and confirm the before and after match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
