mbs-octoml commented on pull request #9848: URL: https://github.com/apache/tvm/pull/9848#issuecomment-1018991079
Great, thanks. Ok my suggestion then is to stick with b) but beef up the comment https://github.com/apache/tvm/blob/1ac01b4aa16b97db91b4254ae2ecdb15451c1d39/include/tvm/ir/expr.h#L179 to capture some of the 'hidden semantics' buried in the device planner commentary: https://github.com/apache/tvm/blob/1ac01b4aa16b97db91b4254ae2ecdb15451c1d39/src/relay/transforms/device_planner.cc#L241). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
