comaniac commented on a change in pull request #10108:
URL: https://github.com/apache/tvm/pull/10108#discussion_r795907748
##########
File path: src/runtime/opencl/opencl_device_api.cc
##########
@@ -122,7 +123,8 @@ void OpenCLWorkspace::GetAttr(Device dev, DeviceAttrKind
kind, TVMRetValue* rv)
corresponding to the number of SIMD entries the heardware
configures.
We need to figure out a way to query this information from the
hardware.
*/
- *rv = 1;
+ const int warp_size = dmlc::GetEnv("TVM_OPENCL_WARP_SIZE", 1);
Review comment:
Although I don't really like environment variable since it creates side
effects, I don't have a better solution just as mentioned by the above TODO.
Maybe that's it for now.
##########
File path: src/auto_scheduler/search_task.cc
##########
@@ -104,8 +104,31 @@ HardwareParams
HardwareParamsNode::GetDefaultHardwareParams(const Target& target
max_threads_per_block, max_vthread_extent,
warp_size);
} else {
// add other opencl target
- auto target_device = target->GetAttr<String>("device", "");
- LOG(FATAL) << "No default hardware parameters for opencl target device:
" << target_device;
+ auto dev = Device{static_cast<DLDeviceType>(device_type), 0};
+ auto device_name = "device_api.opencl";
+ auto func = tvm::runtime::Registry::Get(device_name);
+ ICHECK(func != nullptr) << "Cannot find OpenCL device_api in registry";
+ auto device_api =
static_cast<tvm::runtime::DeviceAPI*>(((*func)()).operator void*());
+
+ tvm::runtime::TVMRetValue ret;
+ device_api->GetAttr(dev,
tvm::runtime::DeviceAttrKind::kMaxSharedMemoryPerBlock, &ret);
+ int max_shared_memory_per_block = ret;
+
+ int max_local_memory_per_block = INT32_MAX;
+
+ device_api->GetAttr(dev,
tvm::runtime::DeviceAttrKind::kMaxThreadsPerBlock, &ret);
+ int max_threads_per_block = ret;
+
+ device_api->GetAttr(dev, tvm::runtime::DeviceAttrKind::kWarpSize, &ret);
+ int warp_size = ret;
+
+ if (warp_size == 1) {
+ LOG(WARNING) << "Th warp size is 1, tuning might crash or stuck.";
Review comment:
```suggestion
LOG(WARNING) << "Warp size 1 is not recommended for OpenCL devices.
Tuning might crash or stuck";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
