comaniac commented on a change in pull request #10108:
URL: https://github.com/apache/tvm/pull/10108#discussion_r796017624
##########
File path: src/runtime/opencl/opencl_device_api.cc
##########
@@ -122,7 +123,8 @@ void OpenCLWorkspace::GetAttr(Device dev, DeviceAttrKind
kind, TVMRetValue* rv)
corresponding to the number of SIMD entries the heardware
configures.
We need to figure out a way to query this information from the
hardware.
*/
- *rv = 1;
+ const int warp_size = dmlc::GetEnv("TVM_OPENCL_WARP_SIZE", 1);
Review comment:
Understood. It's reasonable that the desired API is not always
available. A better solution I'm thinking is the direction of exposing this
option to the hardware parameters in tuning options instead of an environment
variable. For example, the default wrap size of OpenCL devices is always 1, or
user should provide wrap size in hardware parameters otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
