masahi commented on a change in pull request #10118:
URL: https://github.com/apache/tvm/pull/10118#discussion_r796378270
##########
File path: src/relay/op/nn/nn.cc
##########
@@ -283,14 +279,6 @@ InferCorrectLayoutOutput DensePackInferCorrectLayout(const
Attrs& attrs,
const
Array<tvm::relay::Type>& old_in_types) {
auto params = attrs.as<DensePackAttrs>();
ICHECK(params);
- // Respect input layout, if explicitly specified (for example, "NW").
- // However, a packed layout such as "NC8c" is not supported by dense_pack
op. For such cases,
- // we insert a layout transform "NC8c" -> "NC".
- // We do not expect to get a packed layout like "NW8w", which is not
compatitble with "NC",
- // since packing is always done on the "C" axis.
- if (new_in_layouts.size() > 0 && new_in_layouts[0].defined() &&
new_in_layouts[0].ndim() == 2) {
- return InferCorrectLayoutOutput({new_in_layouts[0],
params->weight_layout}, {"NC"}, attrs);
- }
return InferCorrectLayoutOutput({"NC", params->weight_layout}, {"NC"},
attrs);
}
Review comment:
Do we still need `DenseInferCorrectLayout` and
`DensePackInferCorrectLayout` now? I added these functions to workaround alter
layout issues, but that might not be necessary anymore. Can you try remove them
and see what happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
