lazycal commented on pull request #10118: URL: https://github.com/apache/tvm/pull/10118#issuecomment-1027087466
> @lazycal Thank you very much for working on this. I need to review our current layout rewrite implementation to understand this change, so please wait for a few days or longer until I merge this (but I will, definitely). Thanks! I am also reviewing the InferCorrectLayout functions to see if there is anything broken. The broadcast one is one example I just hit. > I really hate `new_` vs `old_` and `_in vs _in2` naming convention in the existing code, it's impossible to understand. More than welcome to clean them up :) Same here. I have 2 proposals: - replace `_in` with `_in_input` and `_in2` with `_in_infer`. - Or more explicit, `_in` with `_in_producer` and `_in2` with `_in_consumer`. Not sure which one would you prefer? Or any other ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
