ekalda commented on a change in pull request #10022:
URL: https://github.com/apache/tvm/pull/10022#discussion_r806892717
##########
File path: python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
##########
@@ -105,22 +195,27 @@ def translate(tir_module, params):
base_addresses : List[util.BaseAddress]
base addresses to be used by the driver
"""
-
+ candidate_regions_for_scratch = [5, 2, 1]
Review comment:
What is the meaning of these numbers? Maybe a comment would help there...
##########
File path: python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
##########
@@ -105,22 +195,27 @@ def translate(tir_module, params):
base_addresses : List[util.BaseAddress]
base addresses to be used by the driver
"""
-
+ candidate_regions_for_scratch = [5, 2, 1]
Review comment:
Thanks for the clarification, makes sense! Yeah, it makes sense to do it
in the follow-up since the CI is green...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
