ekalda commented on a change in pull request #10022:
URL: https://github.com/apache/tvm/pull/10022#discussion_r808902750



##########
File path: python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
##########
@@ -105,22 +195,27 @@ def translate(tir_module, params):
     base_addresses : List[util.BaseAddress]
         base addresses to be used by the driver
     """
-
+    candidate_regions_for_scratch = [5, 2, 1]

Review comment:
       Thanks for adding comment (and the other docstrings as well)! I suppose 
"regions ranging from 0-6" can be interpreted as both, total of 6 or 7 regions, 
depending on the counting philosophy :D I think it is clear enough what is 
meant there though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to