driazati commented on a change in pull request #10247:
URL: https://github.com/apache/tvm/pull/10247#discussion_r807296364
##########
File path: docker/install/ubuntu_install_caffe.sh
##########
@@ -16,17 +16,15 @@
# specific language governing permissions and limitations
# under the License.
-set -e
-set -u
-set -o pipefail
+set -euxo pipefail
Review comment:
any reason not to `-x` everywhere? The docker image build output is
already huge so saving a few lines here and there doesn't seem worth it,
especially when the output is pretty useful in places like CI (i.e see exactly
what ran when a build task failed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
