leandron commented on a change in pull request #10247:
URL: https://github.com/apache/tvm/pull/10247#discussion_r809886120
##########
File path: docker/install/ubuntu_install_caffe.sh
##########
@@ -16,17 +16,15 @@
# specific language governing permissions and limitations
# under the License.
-set -e
-set -u
-set -o pipefail
+set -euxo pipefail
Review comment:
I agree it is useful, but I think it is important we have a standard. At
this point none/some of them have `-x` (I didn’t check)? Perhaps we should move
to having it in all scripts in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
