manupa-arm edited a comment on pull request #8509: URL: https://github.com/apache/tvm/pull/8509#issuecomment-1050656314
We can look into this. @kparzysz-quic , would you be able to submit a PR with an xfail that should have been broken by this PR ? (It is bit harder to track tests that are not in tree). > They are directly caused by float16 not being supported for embedded constants https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/llvm/codegen_params.cc#L137-L157 https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/source/codegen_params.cc#L214-L229 The above are called respectively in the following locations : https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/llvm/codegen_llvm.cc#L1485 https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/source/codegen_c.cc#L673 (These are same code used to codegen LinkedParam node) So, I am not following what is meant here.. Can you elaborate further ? To understand a bit more, would you be able to share the relay.build(...) configuration (targets, executor, runtime) that you are using ? Ideally, if the target does not support -link-params, it should be able to disable it or if the target needs them linked (i.e. not handled via executor) it needs codegen tir.AllocateConst node -- for which the support has been added for all backends of TVM (with tests). By naive, look at the Hexagon codegen it seems like it is extending codegen LLVM. So what we need to understand, what is the expectation of Hexagon backend when linked-param is used ? (I suppose it requires LinkedParam nodes ? ) I am sensing we might need to move link-param from being executor attr to a target attr . cc : @Mousius @d-smirnov Im a bit concerned by the suggestion to revert based on non-tree tests. FYI : @u99127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
