manupa-arm edited a comment on pull request #8509:
URL: https://github.com/apache/tvm/pull/8509#issuecomment-1051006092


   > config = {"relay.FuseOps.link_params":0} 
   
    
https://github.com/apache/tvm/blob/d9fac4f305c5462de4ab08cd220d60b42c0414f7/tests/python/relay/test_pass_fuse_ops.py#L631-L661
   
   I think this is respected. maybe we should need to verify when Executor has 
link-params ? 
   
   But after having read this all again -- the actual issue link-params will be 
set to True if the Executor has it. It seems like hexagon backend was reliant 
on FoldConstant behaviour of always having link-params set to False. Is it not ?
   
   If so the solution might be to provide link-params override for 
FoldConstants as well ?
   
   Something feels like link-params behaviour for FuseOps bass in the main 
compilation pipeline needs to be True. Am I wrong here ? 
   Or are you saying that if you hardcode FuseOps link_params to be False 
always, it all works for you ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to