areusch commented on a change in pull request #10246:
URL: https://github.com/apache/tvm/pull/10246#discussion_r816197791
##########
File path: tests/scripts/task_build.sh
##########
@@ -15,5 +15,41 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-export VTA_HW_PATH=`pwd`/3rdparty/vta-hw
-cd $1 && cmake .. -DCMAKE_BUILD_TYPE=RelWithDebInfo && make $2 && cd ..
+set -eux
+
+VTA_HW_PATH=$(pwd)/3rdparty/vta-hw
+export VTA_HW_PATH
+
+pushd "$1"
+
+# Set up sccache to use S3
+if [ -n "${3+x}" ] && which sccache; then
Review comment:
i see, what i'm worried about is a performance regression if someone
accidentally removes sccache from CI and then not catching it. it seems like
this should maybe be like
```
if [ -n"${3+x}" ]; then
sccache_location=$(which sccache)
if [ -n "${CI+x}" -a "x${sccache_location}" == "x" ]; then
echo "expected sccache but it was not found; aborting since build is
running in CI"
exit 2
fi
fi
```
and then we should manually mark which images we expect it as a hack til we
rebuild them all. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
