driazati commented on a change in pull request #10246:
URL: https://github.com/apache/tvm/pull/10246#discussion_r816203217
##########
File path: tests/scripts/task_build.sh
##########
@@ -15,5 +15,41 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-export VTA_HW_PATH=`pwd`/3rdparty/vta-hw
-cd $1 && cmake .. -DCMAKE_BUILD_TYPE=RelWithDebInfo && make $2 && cd ..
+set -eux
+
+VTA_HW_PATH=$(pwd)/3rdparty/vta-hw
+export VTA_HW_PATH
+
+pushd "$1"
+
+# Set up sccache to use S3
+if [ -n "${3+x}" ] && which sccache; then
Review comment:
makes sense, I'd be more inclined to leave that to a follow up though
since it'll involve some other changes because the CI scripts themselves aren't
aware of what image they're run in so we'd need to thread that through. it
should be simple though and we'll be closely monitoring build jobs in the
meantime anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
