mehrdadh commented on a change in pull request #10311:
URL: https://github.com/apache/tvm/pull/10311#discussion_r819113181
##########
File path: tests/python/contrib/test_hexagon/test_launcher.py
##########
@@ -50,12 +51,12 @@ def test_add(android_serial_number, tvm_tracker_host,
tvm_tracker_port):
func.save(dso_binary_path)
if not android_serial_number:
- pytest.skip("Skip hardware test since ANDROID_SERIAL_NUMBER is not
set.")
+ pytest.skip(msg="Skip hardware test since ANDROID_SERIAL_NUMBER is not
set.")
rpc_info = {
- "rpc_tracker_host" : tvm_tracker_host,
- "rpc_tracker_port" : tvm_tracker_port,
- "rpc_server_port" : 7070,
+ "rpc_tracker_host": tvm_tracker_host,
+ "rpc_tracker_port": tvm_tracker_port,
+ "rpc_server_port": 7070,
Review comment:
Yeah we still have that issue. I think we should try to fix it before
merging your PR on adding the simulator, otherwise it would become flaky and
people complain. Have you seen this issue with running on simulator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
