kparzysz-quic commented on a change in pull request #10311:
URL: https://github.com/apache/tvm/pull/10311#discussion_r819115839
##########
File path: tests/python/contrib/test_hexagon/test_launcher.py
##########
@@ -50,12 +51,12 @@ def test_add(android_serial_number, tvm_tracker_host,
tvm_tracker_port):
func.save(dso_binary_path)
if not android_serial_number:
- pytest.skip("Skip hardware test since ANDROID_SERIAL_NUMBER is not
set.")
+ pytest.skip(msg="Skip hardware test since ANDROID_SERIAL_NUMBER is not
set.")
rpc_info = {
- "rpc_tracker_host" : tvm_tracker_host,
- "rpc_tracker_port" : tvm_tracker_port,
- "rpc_server_port" : 7070,
+ "rpc_tracker_host": tvm_tracker_host,
+ "rpc_tracker_port": tvm_tracker_port,
+ "rpc_server_port": 7070,
Review comment:
I haven't seen it outside of docker. I don't know how to fix it, other
than adding a sleep that will wait long enough for the socket to become
available again... Using different port numbers is guaranteed to work, but it
requires paying attention when writing tests---it would be easy to make a
mistake.
Edit: I don't know why I didn't see this issue when I ran it directly (i.e.
not in docker). ( ﾟoﾟ)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
