areusch commented on a change in pull request #10491:
URL: https://github.com/apache/tvm/pull/10491#discussion_r819937759
##########
File path: python/tvm/contrib/hexagon/build.py
##########
@@ -273,7 +273,11 @@ class HexagonLauncherAndroid(HexagonLauncherRPC):
]
def __init__(
- self, serial_number: str, rpc_info: dict, workspace: Union[str,
pathlib.Path] = None
+ self,
+ serial_number: str,
+ rpc_info: dict,
+ workspace: Union[str, pathlib.Path] = None,
Review comment:
can you document these two ?
##########
File path: tests/scripts/task_python_hexagon.sh
##########
@@ -18,11 +18,10 @@
set -e
set -u
+set -x
source tests/scripts/setup-pytest-env.sh
make cython3
-# unset because hardware does not exist in CI.
-unset ANDROID_SERIAL_NUMBER
-run_pytest ctypes python-contrib-hexagon-no-hwardware
tests/python/contrib/test_hexagon/test_launcher.py
+run_pytest ctypes python-contrib-hexagon
tests/python/contrib/test_hexagon/test_launcher.py --log-cli-level=DEBUG
Review comment:
want to revert log-cli-level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
