kparzysz-quic commented on a change in pull request #10491:
URL: https://github.com/apache/tvm/pull/10491#discussion_r819954013
##########
File path: python/tvm/contrib/hexagon/build.py
##########
@@ -273,7 +273,11 @@ class HexagonLauncherAndroid(HexagonLauncherRPC):
]
def __init__(
- self, serial_number: str, rpc_info: dict, workspace: Union[str,
pathlib.Path] = None
+ self,
+ serial_number: str,
+ rpc_info: dict,
+ workspace: Union[str, pathlib.Path] = None,
+ adb_socket: str = "tcp:5037",
Review comment:
This should be in `rpc_info`. The simulator would simply not use it,
and it would keep the function interfaces unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
