driazati commented on a change in pull request #10425:
URL: https://github.com/apache/tvm/pull/10425#discussion_r821050316
##########
File path: tests/scripts/ci.py
##########
@@ -178,6 +213,8 @@ def docker(name: str, image: str, scripts: List[str], env:
Dict[str, str]):
clean_exit(f"Error invoking Docker: {e}")
except KeyboardInterrupt:
cmd(["docker", "stop", "--time", "1", name])
+ finally:
+ script_file.unlink()
Review comment:
added a guard for an env variable `DEBUG=1` to keep it in
##########
File path: tests/scripts/ci.py
##########
@@ -77,6 +81,11 @@ def cmd(commands: List[Any], **kwargs: Any):
return proc
+def get_build_dir(type: str) -> str:
Review comment:
it already is based on the image in the actual usages, changed the name
to make it more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
