areusch commented on a change in pull request #10425:
URL: https://github.com/apache/tvm/pull/10425#discussion_r825213763
##########
File path: tests/scripts/ci.py
##########
@@ -123,9 +132,11 @@ def check_gpu():
if not isinstance(stdout, list):
return
- products = [s.get("product", "").lower() for s in stdout]
+ products = [s.get("vendor", "").lower() for s in stdout]
Review comment:
should we change to vendors?
##########
File path: tests/scripts/ci.py
##########
@@ -237,9 +277,9 @@ def docs(
check_gpu()
scripts = extra_setup + [
- config,
- f"./tests/scripts/task_build.sh build -j{NPROC}",
- "./tests/scripts/task_ci_setup.sh",
+ config + f" {build_dir}",
+ f"./tests/scripts/task_build.py --build-dir {build_dir}",
+ "python3 -m pip install --user tlcpack-sphinx-addon==0.2.1
synr==0.6.0",
Review comment:
is there a comment elsewhere like `# keep in sync with
tests/scripts/ci.py` and vice verse?
##########
File path: python/tvm/_ffi/libinfo.py
##########
@@ -98,6 +98,10 @@ def find_lib_path(name=None, search_path=None,
optional=False):
use_runtime = os.environ.get("TVM_USE_RUNTIME_LIB", False)
dll_path = get_dll_directories()
+ manual_dll_path = os.getenv("TVM_DLL_PATH")
Review comment:
i think we should say LIB not DLL, since DLL is meaningful only on
windows. also, how does this differ from TVM_LIBRARY_PATH?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
