areusch commented on a change in pull request #10590:
URL: https://github.com/apache/tvm/pull/10590#discussion_r826190685
##########
File path: src/runtime/aot_executor/aot_executor.cc
##########
@@ -132,6 +132,7 @@ PackedFunc AotExecutor::GetFunction(const std::string& name,
*rv = this->GetInputIndex(args[0].operator String());
});
} else {
+ LOG(INFO) << "Unknown packed function: " << name;
Review comment:
for this one, i think `return PackedFunc()` is still abiding by the
`GetFunction` convention, so it might be a bit superfluous to emit a log line
here.
##########
File path: src/target/source/codegen_c_host.h
##########
@@ -42,7 +43,12 @@ class CodeGenCHost : public CodeGenC {
void InitGlobalContext();
void AddFunction(const PrimFunc& f);
-
+ /*!
+ * \brief Add functions from the (unordered) range to the current module in
a deterministic order.
Review comment:
a vector is ordered, so what do you mean by unordered?
##########
File path: src/runtime/vm/executable.cc
##########
@@ -105,7 +105,7 @@ PackedFunc Executable::GetFunction(const std::string& name,
const ObjectPtr<Obje
});
} else {
LOG(FATAL) << "Unknown packed function: " << name;
- return PackedFunc(nullptr);
+ return PackedFunc();
Review comment:
i think this change is equivalent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
