areusch commented on a change in pull request #10590:
URL: https://github.com/apache/tvm/pull/10590#discussion_r827496300
##########
File path: src/target/source/codegen_c_host.cc
##########
@@ -355,22 +374,24 @@ runtime::Module BuildCHost(IRModule mod, Target target) {
Map<String, LinkedParam> linked_params;
PrimFunc aot_executor_fn;
+ std::vector<std::pair<tvm::GlobalVar, tvm::BaseFunc>> funcs;
for (auto kv : mod->functions) {
Review comment:
now this logic is a bit confusing, because it's already trying to
reorder the functions. i think it might make sense to keep all the ordering
logic in one spot. maybe suggest to just put it all in here, since we already
have AddFunction as the helper function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
