kparzysz-quic commented on PR #10907: URL: https://github.com/apache/tvm/pull/10907#issuecomment-1091951093
IMO there are two types of interactions with a device: ones that have to do with setting up the device, and ones that have to do with running code on it. The first group would be, for example, uploading files to it, starting servers, etc, while the second would be loading modules into memory, creating arrays in memory, invoking functions, etc. The first set would be the responsibility of the launcher, while the second would belong to the session. In this view, creating executors would belong to the session, so your changes are ok in that sense. Still, I'd like to make the division of responsibilities clear (not necessarily in this PR though). Finally, I don't like the idea of passing executor factories to the launcher/session code. Executor factories are not persistent objects. What's persistent (i.e. can be saved/loaded) are the actual modules. We should operate in terms of those instead. In particular, the `export_library` stuff does not belong in either launcher or session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
