Lunderberg commented on PR #10907: URL: https://github.com/apache/tvm/pull/10907#issuecomment-1092913946
> We could have a utility function somewhere in tvm/contrib/hexagon that does the export_library together with the link-step workaround. That should save some work from the tests using AoT. Good point, and I like the idea of centralizing the link-step workaround, so it will only need to be removed from one spot once it is not longer needed. I was thinking that it would make sense to have it directly in `tvm.contrib.hexagon.create_aot_shared`, since right now it is necessary for all invocations. The utility function would get a lot of the same benefits. I had been hoping to also avoid requiring functionality tests to handle file management and cleanup, as the file management isn't relevant to the behavior being tested. I'm open to having a testing-specific utility function, though I'd still prefer having it be part of the session object, as that would allow for additional ergonomic benefits in the future (e.g. Uploads triggered through the session having a session-specific prefix to avoid name collisions, and being cleaned up after the session.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
