avulisha commented on code in PR #10953:
URL: https://github.com/apache/tvm/pull/10953#discussion_r847321634
##########
src/runtime/vulkan/vulkan_instance.cc:
##########
@@ -59,6 +59,14 @@ VulkanInstance::VulkanInstance() {
std::vector<const char*> required_extensions{};
std::vector<const char*>
optional_extensions{"VK_KHR_get_physical_device_properties2"};
+ // Check if RGP support is needed. If needed, enable VK_EXT_debug_utils
extension for
+ // inserting debug labels into the queue.
+ const char* val = getenv("TVM_USE_AMD_RGP");
Review Comment:
> Use `BoolEnvironmentVar`
>
>
https://github.com/apache/tvm/blob/ef7143e1fc1a12993f584ce37dbde38b75966b40/src/runtime/vulkan/vulkan_instance.cc#L36
Hi @masahi,
Thanks for your time in reviewing the changes. Will Implement your
suggestion.
Thanks,
Anurag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
