avulisha commented on code in PR #10953:
URL: https://github.com/apache/tvm/pull/10953#discussion_r848366715
##########
src/runtime/vulkan/vulkan_stream.h:
##########
@@ -110,6 +125,7 @@ class VulkanStream {
std::unordered_map<VkDescriptorSet, std::vector<VulkanStreamToken>>
deferred_tokens_;
std::vector<std::function<void(VulkanStreamState*)>> deferred_kernels_;
VkCommandPool cmd_pool_;
+ VulkanStreamProfiler* profiler_;
Review Comment:
Hi @masahi,
We have implemented the AMD-specific trace capture logic (debug labels
insertion) into a separate class AmdRgpProfiler, which is derived from
VulkanStreamProfiler. During the VulkanStream creation, the AmdRgpProfiler is
instantiated and assigned to VulkanStreamProfiler *profiler. Doing this will
help in overriding the default VulkanStreamProfiler->capture() with the
AmdRgpProfiler->capture(). If we modify the VulkanStreamProfiler *profiler_ to
VulkanStreamProfiler profiler_, the overriding of VulkanStreamProfiler
->capture() with AmdRgpProfiler->capture() will not work. Because of this
reason, I would suggest using the existing flow.
Thanks,
Anurag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
