adstraw commented on code in PR #10905:
URL: https://github.com/apache/tvm/pull/10905#discussion_r847809699
##########
src/tir/ir/buffer.cc:
##########
@@ -480,8 +479,14 @@ Buffer Buffer::MakeSlice(Array<PrimExpr> begins,
Array<PrimExpr> extents) const
return MakeStrideView().MakeSlice(begins, extents);
}
}
- return Buffer(n->data, n->dtype, extents, strides, elem_offset[0], n->name +
"_slice",
- n->data_alignment, 0, n->buffer_type);
+ Buffer slice(n->data, n->dtype, extents, strides, elem_offset[0], n->name +
"_slice",
+ n->data_alignment, 0, n->buffer_type);
+ if (elem_offset.size() != 1) {
+ // Sentinel value for ArgBinder::BindBuffer to state that any usage
+ // of element offset is invalid.
+ slice.CopyOnWrite()->elem_offset = PrimExpr();
Review Comment:
@Lunderberg Let me know if you are OK with the comment rewrite here
including the `TODO` I wrote related to PR #10816.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
