gromero commented on code in PR #10963:
URL: https://github.com/apache/tvm/pull/10963#discussion_r849700697
##########
python/tvm/autotvm/measure/measure_methods.py:
##########
@@ -496,7 +497,8 @@ def set_task(self, task):
def _build_func_common(measure_input, runtime=None, check_gpu=None,
build_option=None):
"""Common part for building a configuration"""
target, task, config = measure_input
- target, task.target_host = Target.check_and_update_host_consist(target,
task.target_host)
+ assert not isinstance(target, (Map, dict)), "It's expected that 'target'
is a string here."
Review Comment:
@Mousius I think we could but what would be the achievement exactly with a
unit test for that internal function (`_build_func_common`)? More broadly, what
has been our policy about testing `assert` in TVM code? Should we test all the
asserts? I recall there were a discussion some time ago about it but could not
find the PR :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
