Mousius commented on code in PR #10963:
URL: https://github.com/apache/tvm/pull/10963#discussion_r849745895
##########
python/tvm/autotvm/measure/measure_methods.py:
##########
@@ -496,7 +496,7 @@ def set_task(self, task):
def _build_func_common(measure_input, runtime=None, check_gpu=None,
build_option=None):
"""Common part for building a configuration"""
target, task, config = measure_input
- target, task.target_host = Target.check_and_update_host_consist(target,
task.target_host)
+ target, _ = Target.check_and_update_host_consist(target, task.target_host)
Review Comment:
Just coming back to this, if the expectation is that we don't pass those
things into `check_and_update_host_consist` then shouldn't it validate the
inputs itself? As in, place the assert within `check_and_update_host_consist`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]