Mousius commented on code in PR #10963:
URL: https://github.com/apache/tvm/pull/10963#discussion_r854324541
##########
python/tvm/autotvm/measure/measure_methods.py:
##########
@@ -496,7 +496,7 @@ def set_task(self, task):
def _build_func_common(measure_input, runtime=None, check_gpu=None,
build_option=None):
"""Common part for building a configuration"""
target, task, config = measure_input
- target, task.target_host = Target.check_and_update_host_consist(target,
task.target_host)
+ target, _ = Target.check_and_update_host_consist(target, task.target_host)
Review Comment:
> it's really tricky to mentally model what may happen in all the various
scenarios with that function
One excellent reason to have comprehensive test cases for these internal
functions 😸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
