Mousius commented on code in PR #10963:
URL: https://github.com/apache/tvm/pull/10963#discussion_r854341978
##########
python/tvm/autotvm/measure/measure_methods.py:
##########
@@ -496,7 +497,8 @@ def set_task(self, task):
def _build_func_common(measure_input, runtime=None, check_gpu=None,
build_option=None):
"""Common part for building a configuration"""
target, task, config = measure_input
- target, task.target_host = Target.check_and_update_host_consist(target,
task.target_host)
+ assert not isinstance(target, (Map, dict)), "It's expected that 'target'
is a string here."
Review Comment:
I'd rather not leave the `assert` in to remember when we refactor
`check_and_update_host_consist` given this likely is the wrong place for it and
unless someone wants to check back on this PR it won't be clear why it's where
it is. Can we leave the `assert` out here and rely on the refactor for
`check_and_update_host_consist` to robustify it further down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
