mehrdadh commented on code in PR #11065:
URL: https://github.com/apache/tvm/pull/11065#discussion_r854410756
##########
tests/python/contrib/test_hexagon/test_launcher.py:
##########
@@ -332,7 +346,7 @@ def test_aot_executor(hexagon_session):
@requires_hexagon_toolchain
-def test_aot_executor_multiple_conv2d(hexagon_session):
+def test_aot_executor_multiple_conv2d(hexagon_launcher, aot_target_kind):
Review Comment:
so AoT host targets are pytest parameters and they are not used for graph
executor. If I add it in `hexagon_session` it will generate extra tests for
graph executor which doesn't make sense. I added aot_target and aot_host_target
as fixtures.
We could fix this by adding aot_hexagon_session fixture.
##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -60,10 +60,10 @@ def __init__(
rpc_receive_buffer_size_bytes: int = 2 * 1024 * 1024,
):
self._launcher = launcher
- self._session_name = session_name
- self._remote_stack_size_bytes = remote_stack_size_bytes
- self._rpc_receive_buffer_size_bytes = rpc_receive_buffer_size_bytes
- self._remote_kw = remote_kw
+ self._session_name: str = session_name
Review Comment:
added.
##########
tests/python/contrib/test_hexagon/test_launcher.py:
##########
@@ -270,8 +271,20 @@ def _workaround_create_aot_shared():
)
+def get_target_and_session(target_kind: str):
+ if target_kind == "c":
+ target_hexagon = tvm.target.hexagon("v68")
+ session_name = "hexagon-rpc"
+ elif target_kind.startswith("llvm"):
+ target_hexagon = target_kind
+ session_name = "cpu-rpc"
+ else:
+ assert False, "Incorrect target_kind: {target_kind}. Options are [c,
llvm]."
+ return target_hexagon, session_name
Review Comment:
added. thanks!
##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -286,6 +294,11 @@ def _aot_executor_from_factory(
for target in module.target.values()
Review Comment:
Can you clarify where these two links point at?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
