Lunderberg commented on PR #11065: URL: https://github.com/apache/tvm/pull/11065#issuecomment-1105745641
Looks like the linter wasn't recognizing the `hasattr` as ensuring that there was a definition for `self._device`. From [this thread](https://github.com/PyCQA/pylint/issues/2315#issuecomment-628331369), it looks like that's a bug with pylint, fixed at some point between March 2020 and December 2021. The CI is currently running pylint 2.4.4, released in November 2019, so it wouldn't be unreasonable to update the pylint version at some point. Updating to use `self._device = None` instead of `hasattr` LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
