petersalas commented on code in PR #11094:
URL: https://github.com/apache/tvm/pull/11094#discussion_r855727390
##########
python/tvm/contrib/popen_pool.py:
##########
@@ -213,12 +223,19 @@ def send(self, fn, args=(), kwargs=None, timeout=None):
# pylint: disable=import-outside-toplevel
import cloudpickle
+ if self._proc is not None and self._maximum_uses and
self._remaining_uses == 0:
Review Comment:
We can't quite do that because we have to wait for the `recv` call (at the
start of `send` is "ok" only by relying on the contract above):
```
The caller must call recv before calling the next send in
order to make sure the timeout and child process exit
won't affect the later requests.
```
But, I can move this to the end of `recv` if you'd like? I'm indifferent --
I put it in `send` to try consolidate (most) of the logic in one function but I
certainly don't feel strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
