AndrewZhaoLuo commented on code in PR #11094:
URL: https://github.com/apache/tvm/pull/11094#discussion_r855732811
##########
python/tvm/contrib/popen_pool.py:
##########
@@ -133,7 +139,11 @@ def kill(self):
self._proc.kill()
except OSError:
pass
+
+ # Join the child process to avoid zombie processes
+ self.join(timeout=1.0)
Review Comment:
Hmm, so freeing the pid entry is non-deterministic in the other way. I see.
I think being this explicit has definite advantages then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
