Lunderberg commented on code in PR #11130:
URL: https://github.com/apache/tvm/pull/11130#discussion_r858851943
##########
src/arith/analyzer.cc:
##########
@@ -108,29 +108,25 @@ bool Analyzer::CanProveEqual(const PrimExpr& lhs, const
PrimExpr& rhs) {
}
bool Analyzer::CanProve(const PrimExpr& expr) {
- if (const auto* ptr = expr.as<IntImmNode>()) {
- return ptr->value != 0;
Review Comment:
Sounds good, and added back in. I hadn't done any performance tests, but
had been expecting that the call to Simplify would be low cost as it starts by
checking whether the value is a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
