tqchen commented on code in PR #11130:
URL: https://github.com/apache/tvm/pull/11130#discussion_r858858578
##########
src/arith/analyzer.cc:
##########
@@ -108,29 +108,25 @@ bool Analyzer::CanProveEqual(const PrimExpr& lhs, const
PrimExpr& rhs) {
}
bool Analyzer::CanProve(const PrimExpr& expr) {
- if (const auto* ptr = expr.as<IntImmNode>()) {
- return ptr->value != 0;
Review Comment:
I agree with what you said(simplify also starts to be low cost), so I could
be over simplifying here :) In the meantime being explicit without relying on
subsequent behavior (which would be one cost of call) can be helpful a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
