areusch commented on code in PR #10934:
URL: https://github.com/apache/tvm/pull/10934#discussion_r858929674
##########
tests/scripts/ci.py:
##########
@@ -189,10 +189,9 @@ def docker(name: str, image: str, scripts: List[str], env:
Dict[str, str], inter
docker_bash = REPO_ROOT / "docker" / "bash.sh"
- command = [docker_bash, "--name", name]
+ command = [docker_bash, "-t", "--name", name]
Review Comment:
would this poison Jenkins logs with lots of `[2m` or whatever?
##########
tests/scripts/task_cpp_unittest.sh:
##########
@@ -40,10 +39,20 @@ if grep crttest build/Makefile > /dev/null; then
make crttest # NOTE: don't parallelize, due to issue with build deps.
fi
-cd build && ctest --gtest_death_test_style=threadsafe && cd ..
+if grep crttest build/build.ninja > /dev/null; then
Review Comment:
i think it would be better to configure expectations here from e.g.
CI_RUN_CRTTEST or a command-line arg to this script, otherwise we could
silently fail if someone removes crttest as a target
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
