driazati commented on code in PR #10934:
URL: https://github.com/apache/tvm/pull/10934#discussion_r860276921


##########
tests/scripts/ci.py:
##########
@@ -189,10 +189,9 @@ def docker(name: str, image: str, scripts: List[str], env: 
Dict[str, str], inter
 
     docker_bash = REPO_ROOT / "docker" / "bash.sh"
 
-    command = [docker_bash, "--name", name]
+    command = [docker_bash, "-t", "--name", name]

Review Comment:
   this is only used interactively right now so it's not a big deal though, but 
we can check for `sys.stdout.isatty`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to