Lunderberg commented on PR #11235:
URL: https://github.com/apache/tvm/pull/11235#issuecomment-1122381917

   > Thanks for the PR, I like this change.
   
   Thank you, and I'm liking it as well.  It 
   
   > There is a failing test case 
test_reverse_compute_at_floordiv_and_floormod_indices seems relevant, probably 
some affine analysis is broken
   
   Yeah, so far I've narrowed it down to the handling of cases like `(iter + 
16*var)//16`.  This doesn't introduce padding, but the nonzero offset would 
make it fail `DetectIterMap` in [this 
check](https://github.com/apache/tvm/blob/main/src/arith/iter_affine_map.cc#L1147).
  This boils up to [the call to 
`AnalyzerRegionUpperBound`](https://github.com/apache/tvm/blob/main/src/tir/schedule/state.cc#L336),
 resulting in incorrect results.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to