Lunderberg commented on PR #11235:
URL: https://github.com/apache/tvm/pull/11235#issuecomment-1124994737

   > > (iter + 16*var)//16
   > 
   > Hi~ Does it mean pass index like `(dom_irrelavant_base + i) // 16` can not 
pass `DetectIterMap`? I encounter a similar issue in a different domain, where 
I try to use `compute_at` schedule to make tiles on computation block with 
floormod/floordiv indices.
   
   Prior to this PR, that is correct.  The check on the main branch is 
[here](https://github.com/apache/tvm/blob/366a5669/src/arith/iter_affine_map.cc#L1147),
 which requires the offset in a numerator to be zero.  After this PR, an index 
like `(dom_irrelevant_base + i)//16` could be passed if either (a) 
`dom_irrelevant_base` can be proven to be a multiple of 16, or (b) you call 
`DetectPaddedIterMap`, which may introduce padding such that `(left_pad + 
dom_irrelevant_base) % 16 == 0` and that `(left_pad + dom_irrelevant_base + 
i.extent + right_pad) % 16 == 0`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to