vvchernov commented on code in PR #11504:
URL: https://github.com/apache/tvm/pull/11504#discussion_r885961977
##########
src/runtime/ndarray.cc:
##########
@@ -240,6 +240,10 @@ NDArray NDArray::FromDLPack(DLManagedTensor* tensor) {
data->SetDeleter(Internal::DLPackDeleter);
// fill up content.
data->manager_ctx = tensor;
+ ICHECK(::tvm::runtime::IsContiguous(tensor->dl_tensor))
+ << "DLManagedTensor is not contiguous. It does not support for now";
Review Comment:
Ok, I will redo it. But I based on similar description in other ICHECK. I
think TVM design assumes contiguous tensors only and what we can potentially
support in the future it is copying from incontiguous to contiguous ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
