tkonolige commented on code in PR #11504:
URL: https://github.com/apache/tvm/pull/11504#discussion_r885979953
##########
src/runtime/ndarray.cc:
##########
@@ -240,6 +240,10 @@ NDArray NDArray::FromDLPack(DLManagedTensor* tensor) {
data->SetDeleter(Internal::DLPackDeleter);
// fill up content.
data->manager_ctx = tensor;
+ ICHECK(::tvm::runtime::IsContiguous(tensor->dl_tensor))
+ << "DLManagedTensor is not contiguous. It does not support for now";
Review Comment:
Personally I think saying something will be supported in the future doesn't
really add any useful information. But, if you do want to say that "Only
contiguous DLManagedTensors are currently supported." would be a better message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
