Mousius commented on PR #11327: URL: https://github.com/apache/tvm/pull/11327#issuecomment-1143549954
> i've elaborated i think clearly enough two classes of functions (procedural and "functional") which are more clearly expressed using different forms of if-else and therefore i think this issue would benefit from author/reviewer judgement. @areusch, I'm still of the opinion that reducing the overall consistency of our codebase based on individuals interpretations of a function style is a bad idea and that need for elaboration will occur in code review repeatedly. The benefit of having a linter is to have a consistent coding style, and not having to discuss it in code reviews. Introducing author/reviewer judgement instead of codified rules means there's the addition of stylistic choices added to the code review process, which could easily have been avoided, and means we increase the diversity of the coding style across the project. Discussions surrounding linter rules are nearly always about individual coding styles, otherwise we would use the tooling default rules and accept that our individual preferences aren't taken into account (which would also increase consistency across a wider landscape of projects using the same tooling). If we, as a project, want to carry the code review burden of explaining how to format code to contributors then I don't see a reason not to merge this, though the responsible party will likely need to add examples in the code review guidelines to explain when is appropriate to use either case for future contributors given the tooling will no longer provide assistance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
