Mousius commented on PR #11327: URL: https://github.com/apache/tvm/pull/11327#issuecomment-1147655707
> Thank you for the feedback on it @Mousius . I definitely see your point on having a consistent style, and that slow relaxation of linter rules converges on having no linter rules. I'd also agree about linter rules beings about individual coding style, but would include the tooling defaults in that category as set by the individual coding style of the linter's authors, and so there's a benefit in having project-specific settings. Just to extend upon your last statement @Lunderberg, I believe some of it is down to personal preference on the part of the linter author but that there's also the specialisation of being the author of such a tool to consider. > we could discuss this a bit further at community meeting, if we'd like to have a time-boxed high-bandwidth discussion. thoughts? @areusch, I personally echo the sentiment of @Lunderberg in that _"the time spent on the discussion has outweighed the benefit from the change, so I'm okay with either outcome as a way of concluding the discussion"_. My only ask is that if this gets merged, we clearly document what we're expecting to occur in each case, within the code review guidelines for future contributors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
