yangulei commented on code in PR #11513:
URL: https://github.com/apache/tvm/pull/11513#discussion_r889912462
##########
src/runtime/contrib/dnnl/dnnl_json_runtime.cc:
##########
@@ -1041,6 +1056,70 @@ class DNNLJSONRuntime : public JSONRuntimeBase {
{DNNL_ARG_DST, dst_memory}});
}
+ void DensePack(const size_t& nid) {
Review Comment:
`DensePack` is almost identical to the original `Dense` function. Could you
apply your change directly to the `Dense` function to eliminate this
duplication? Only two lines including the definition of `weight_layout` and
`weight_md` needs to be modified. And we get bf16 support in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
