billishyahao commented on code in PR #11513:
URL: https://github.com/apache/tvm/pull/11513#discussion_r893223167
##########
src/relay/backend/contrib/dnnl/codegen.cc:
##########
@@ -507,6 +540,9 @@ class DNNLJSONSerializer : public
backend::contrib::JSONSerializer {
std::vector<std::string> op_list = ParsingOpList(name);
call = GetRootCall(fn->body.as<CallNode>(), op_list.size() - 1,
op_list);
ICHECK(call->op.as<OpNode>()) << "Not op node";
+ } else if (name.find("gelu") != std::string::npos) {
Review Comment:
Hi @apeskov , I agree! For generalization purpose, we should extend gelu
fusion to other operators such as conv. But for this patch, I would like to
make it dedicated to enabling dense+bias+gelu. I will create a issue to track
this and try to propose another patch to cover the case. The new pattern
following with `gelu` is only dispatched by dense operator so I made an
assumption here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
